Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range
From: Greg KH
Date: Sun Feb 15 2026 - 01:52:35 EST
On Sat, Feb 14, 2026 at 09:23:45PM +0200, Ofek Almog wrote:
> (Resending as plain text, apologies if you received a previous HTML version)
>
> Hi Andy, Ethan,
>
> Thank you both for the review.
>
> Regarding the fsleep() suggestion - understood, that clearly seems
> like the right helper to use here.
>
> Regarding the completion mechanism logic - I completely agree that the
> current infinite loop polling is fragile. However, as this is my very
> first contribution and I do not have the hardware to verify logic
> changes, I am hesitant to refactor the synchronization mechanism
> blindly.
>
> Would you prefer I send a v2 that strictly switches to fsleep() as an
> incremental improvement over msleep(), or should I drop this patch
> altogether until someone with the hardware can refactor the logic
> properly?
Please drop it, see the archives for why (you need someone with the
hardare and specs to figure out what needs to be done.)
thanks,
greg k-h