Re: [PATCH] staging: rtl8723bs: rename camelCase variables
From: Nikolay Kulikov
Date: Sun Feb 15 2026 - 03:05:10 EST
On Sat, Feb 07, 2026 at 02:43:16PM +0100, Greg KH wrote:
> Why did you pick these names? You kept the "p" prefix for some reason,
> which is "Hungarian" notation, and is not a kernel coding style, so
> shouldn't you just use a name that reflects what this variable is doing,
> and not encode the type in it?
Hello, thanks for the feedback - you're absolurely right about the
"Hungarian" notation. I should have removed the 'p' prefix,
I see that Rivka has already fixed "pHT_info_ie" (with Reviewed-by from
Ethan Tidmore). To avoid duplication, i will send v2 that only fixes
"pHT_caps_ie"
Thanks for teaching,
Nikolay