Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

[Krzysztof Kozlowski]

On 16/02/2026 10:23, Miclaus, Antoniu wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: Saturday, February 7, 2026 12:53 PM
>> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
>> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael
>> <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>;
>> David Lechner <dlechner@xxxxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>;
>> Andy Shevchenko <andy@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
>> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
>> <conor+dt@xxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH 3/6] dt-bindings: iio: adc: adi,ad4080: add support for
>> AD4085
>>
>> [External]
>>
>> On Fri, Feb 06, 2026 at 03:08:22PM +0200, Antoniu Miclaus wrote:
>>> Add device tree binding support for the AD4085 16-bit SAR ADC.
>>> Add adi,ad4085 to the compatible enum.
>>>
>>> A fallback compatible string to adi,ad4080 is not appropriate as the
>>> AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
>>> different driver configuration.
>>>
>>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
>>
>> Squash the patches. You just added one line, but commit msg is 5 lines.
>> Exactly copied from previous commit.
> 
> Sorry for missing your comments for v2.
> I wanted to keep the structure of the patch series similar to what was already accepted and integrated into the main branch:

And I want flying inflatable yellow duck. We do not use arguments that
we want, but we use arguments WHY we want something or why community
should want something.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83185903b4eca86e0c7145d62e55de768eeb9e7b
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6c3e7265734bbde7347d44fa8e5720bcc5ad5cea
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d34ad6467200380c8f8337ceefee9f3d8cee5492
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f11de95215311816595a1f2ee81cf8239d9b660a
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4028cbcf3415f6e0810326d87c6e0b494814ae12
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=45e81d6ac0e1af349e5da050dc0be48a72fad9dd

>

No, because it does not make the code easier to handle.

Best regards,
Krzysztof