Re: [PATCH 1/2] mfd: lpc_ich: expose the GPIO controller cell's software node
From: Bartosz Golaszewski
Date: Mon Feb 16 2026 - 05:16:06 EST
On Mon, Feb 16, 2026 at 10:18 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Feb 16, 2026 at 09:51:18AM +0100, Bartosz Golaszewski wrote:
> > On Fri, Feb 13, 2026 at 10:16 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > On Fri, Feb 13, 2026 at 09:25:24AM +0100, Bartosz Golaszewski wrote:
>
> ...
>
> > > > +const struct software_node lpc_ich_gpio_swnode = {
> > > > + .name = "gpio_ich",
> > > > +};
> > > > +EXPORT_SYMBOL(lpc_ich_gpio_swnode);
> > >
> > > Can we export in a dedicated namespace? Perhaps "LPC_ICH"?
> >
> > I can't test it so I would prefer to reduce the amount of runtime risk
> > introduced by this change. We can do it separately later.
>
> I didn't get this, In this patch you use _NS (And in any case this should be _GPL).
> In the other you need to add MODULE_IMPORT_NS(). There is nothing which needs a HW
> to test.
>
We're adding surface for an import failure but whatever, I don't mind adding it.
Bart