Re: [PATCH] smb: smbdirect: select CONFIG_SG_POOL

[Stefan Metzmacher]

Am 16.02.26 um 12:48 schrieb Arnd Bergmann:
> On Mon, Feb 16, 2026, at 12:15, Stefan Metzmacher wrote:
> > Hi Arnd,
> >
> > I'm wondering what the top commit is that you where compiling,
> > I guess that's before the 'smb: client: make use of smbdirect.ko'
> > commit.
>
> I'm on today's linux-next-20260213, which contains
>
> 4c91b67f87ac smb: client: fix data corruption due to racy lease checks
> 3774289f525c smb/client: move NT_STATUS_MORE_ENTRIES
> 617a5d2473dc smb/client: rename to NT_ERROR_INVALID_DATATYPE
> fa34d0a57033 smb/client: rename to NT_STATUS_SOME_NOT_MAPPED
> 4da735c48a27 smb/client: map NT_STATUS_PRIVILEGE_NOT_HELD
> 3e5f08342860 smb/client: map NT_STATUS_MORE_PROCESSING_REQUIRED
> e4424687fc6d smb/client: map NT_STATUS_BUFFER_OVERFLOW
> ba39063ca3ee smb/client: map NT_STATUS_NOTIFY_ENUM_DIR
> 66dc58bdbd7c cifs: SMB1 split: Remove duplicate include of cifs_debug.h
> 72f4d4803486 smb: client: fix regression with mount options parsing
> 72f4d4803486 smb: client: fix regression with mount options parsing
> 4c91b67f87ac smb: client: fix data corruption due to racy lease checks
> 3774289f525c smb/client: move NT_STATUS_MORE_ENTRIES
> 617a5d2473dc smb/client: rename to NT_ERROR_INVALID_DATATYPE
> fa34d0a57033 smb/client: rename to NT_STATUS_SOME_NOT_MAPPED
> 4da735c48a27 smb/client: map NT_STATUS_PRIVILEGE_NOT_HELD
> 3e5f08342860 smb/client: map NT_STATUS_MORE_PROCESSING_REQUIRED
> e4424687fc6d smb/client: map NT_STATUS_BUFFER_OVERFLOW
> ba39063ca3ee smb/client: map NT_STATUS_NOTIFY_ENUM_DIR
> 66dc58bdbd7c cifs: SMB1 split: Remove duplicate include of cifs_debug.h
> 72f4d4803486 smb: client: fix regression with mount options parsing
> d53f4d93f3d6 Merge tag 'v7.0-rc-part1-ksmbd-and-smbdirect-fixes' of git://git.samba.org/ksmbd
> 8f7df60fe063 ("ksmbd: fix non-IPv6 build")
> ...
>
> > As we have this at the end of the patchset in ksmbd-for-next:
> >
> > fs/smb/common/smbdirect/Kconfig

Ah, ok, that was because Steve only had 1/3 of the patchset
applied last week.

So this problem should be gone in the next linux-next round,
will not have the problem.

> This file is not in linux-next as of today, as far as I can tell.
>
> > config SMB_COMMON_SMBDIRECT
> >           def_tristate n
> >           depends on INFINIBAND && INFINIBAND_ADDR_TRANS
> >           depends on m || INFINIBAND != m
> >           select SG_POOL
> >
> > I'll try to change the patches to have your hunk
> > in the temporary phase in the patchset where we use
> > smbdirect_all_c_files, as it's gone at the end of
> > the patchset.

And once I tested my updated patchset and Steve
applied it, it should even work for every single
patch.

metze