Re: [PATCH v2 21/25] media: i2c: imx283: Provide an effective pixel array mode

[Jai Luthra]

Quoting Kieran Bingham (2026-02-13 19:32:00)
> Provide a mode that includes all effective pixels which includes a 12
> pixel margin for colour processing on all edges.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>

Reviewed-by: Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/i2c/imx283.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/media/i2c/imx283.c b/drivers/media/i2c/imx283.c
> index d001bfb5e241..75a35d9db05d 100644
> --- a/drivers/media/i2c/imx283.c
> +++ b/drivers/media/i2c/imx283.c
> @@ -183,6 +183,13 @@ static const struct v4l2_rect imx283_native_area = {
>         .height = 3710,
>  };
>  
> +static const struct v4l2_rect imx283_effective_area = {
> +       .top = 16 + 12, /* Clamp + Ignored area*/
> +       .left = 96,
> +       .width = 5496,
> +       .height = 3672,
> +};
> +
>  static const struct v4l2_rect imx283_active_area = {
>         .top = 16,
>         .left = 96,
> @@ -538,6 +545,21 @@ static const struct imx283_mode supported_modes_12bit[] = {
>  
>                 .crop = imx283_active_area,
>         },
> +       {
> +               /* Effective Pixel Mode : 5496x3672 */
> +               .scan = &imx283_scan_modes[IMX283_MODE_0],
> +
> +               .width = 5496,
> +               .height = 3672,
> +               .min_hmax = 5914, /* 887 @ 480MHz/72MHz */
> +               .min_vmax = 3793, /* Lines */
> +
> +               /* 20.00 FPS */
> +               .default_hmax = 6000, /* 900 @ 480MHz/72MHz */
> +               .default_vmax = 4000,
> +
> +               .crop = imx283_effective_area,
> +       },
>         {
>                 /* 20MPix 21.40 fps readout mode 0 */
>                 .scan = &imx283_scan_modes[IMX283_MODE_0],
> 
> -- 
> 2.52.0
>