Re: [PATCH] rust: print: Document SAFETY invariants in rust_fmt_argument and call_printk
From: Miguel Ojeda
Date: Mon Feb 16 2026 - 15:32:13 EST
On Fri, Feb 13, 2026 at 6:31 AM Ali Zain <alizainuimx@xxxxxxxxx> wrote:
>
> Replace remaining "SAFETY: TODO" comments with proper explanations.
>
> Document why the raw pointer cast to `fmt::Arguments` is valid
> and clarify the invariants required when calling `_printk`
> through FFI.
>
> This does not change behaviour.
>
> v2:
> - Fix rustfmt formatting issue reported by 0-day CI.
> - Remove extra blank line before unsafe block.
>
> Signed-off-by: Ali Zain <alizainuimx@xxxxxxxxx>
Since this is meant to be v2, please mark your patch as v2 using flags
like `git format-patch -v2`.
What is the base for this patch, by the way?
Also, you included the changelog within the commit message -- they
usually go after the first `---` line, so that it is not included.
There is also an unrelated change in `print.rs`.
I hope that helps.
Cheers,
Miguel