Re: [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs

[Svyatoslav Ryhel]

вт, 17 лют. 2026 р. о 10:15 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>
> On 17/02/2026 09:02, Svyatoslav Ryhel wrote:
> > вт, 17 лют. 2026 р. о 09:22 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
> >>
> >> On 26/01/2026 20:07, Svyatoslav Ryhel wrote:
> >>> Each memory client has unique hardware ID, add these IDs.
> >>>
> >>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> >>> Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> >>> Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> >>> ---
> >>>  include/dt-bindings/memory/tegra114-mc.h | 67 ++++++++++++++++++++++++
> >>
> >> This is never a separate commit. Squash with the binding.
> >>
> >
> > Always was and now it suddenly is not? Maybe you should consider
>
> It never was, by the rules. I give this review all the time.
>

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/memory?h=next-20260216&id=96b0239bbd6153b70c14c80664ebb43cd2ddacd9
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/memory?h=next-20260216&id=825c7f4aa2866b77c0238855e2f58d56d2f13eae
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/memory?h=next-20260216&id=f25696bce9604dbfd8d956da6023d18a05ec8ed3
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/memory?h=next-20260216&id=24a7eaea0a941c9e5e243ffb40073dcafecd3c11

I don't see any of these are squashed with any binding, but ok, whatever.

> > fixing checkpatch since it complains that binding and header must be 2
> > separate commits.
>
> I considered, I guess many considered... but the problem is:
>
> IT DOES NOT SAY THAT. There is no checkpatch warning, at least on recent
> tree.
>

Interesting, it is not now, but it definitely was. Acknowledged.

> Best regards,
> Krzysztof