Re: [Linux-stm32] [PATCH] spi: stm32: Use NULL instead of 0 for pointer

[Amelie Delaunay]

On 2/16/26 09:58, Krzysztof Kozlowski wrote:
> Pointers should use NULL instead of explicit '0', as pointed out by
> sparse:
>
>    spi-stm32.c:1659:65: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>


Reviewed-by: Amelie Delaunay <amelie.delaunay@xxxxxxxxxxx>

Thank you for providing the patch to fix this warning.

Regards,
Amelie

> ---
>   drivers/spi/spi-stm32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index b99de8c4cc99..38f6bba38b07 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -1656,7 +1656,7 @@ static int stm32_spi_transfer_one_dma(struct stm32_spi *spi,
>   			ret = stm32_spi_prepare_rx_dma_mdma_chaining(spi, xfer, &rx_dma_conf,
>   								     &rx_dma_desc, &rx_mdma_desc);
>   			if (ret) { /* RX DMA MDMA chaining not possible, fallback to DMA only */
> -				rx_dma_conf.peripheral_config = 0;
> +				rx_dma_conf.peripheral_config = NULL;
>   				rx_dma_desc = NULL;
>   			}
>   		}