Re: [PATCH v13 3/3] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[tessolveupstream]

On 11-02-2026 11:46, Dmitry Baryshkov wrote:
> On Wed, Feb 11, 2026 at 09:55:34AM +0530, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
>>
>> The Carrier Board supports several display configurations, HDMI and
>> LVDS. Both configurations use the same base hardware, with the display
>> selection controlled by a DIP switch.
>>
>> Use a DTBO file, talos-evk-lvds-auo,g133han01.dtso, which defines an
>> overlay that disables HDMI and adds LVDS. The DTs file talos-evk
>> can describe the HDMI display configurations.
>>
>> According to the hardware design and vendor guidance, the WiFi PA
>> supplies VDD_PA_A and VDD_PA_B only need to be enabled at the same time
>> as asserting WLAN_EN.
>>
>> On this platform, WiFi enablement is controlled via the WLAN_EN GPIO
>> (GPIO84), which also drives the VDD_PA_A and VDD_PA_B power enables.
>> Remove the VDD_PA_A and VDD_PA_B regulator nodes from the device tree
>> and rely on WLAN_EN to enable WiFi functionality.
>>
>> The initial device tree includes support for:
>> - CPU and memory
>> - UART
>> - GPIOs
>> - Regulators
>> - PMIC
>> - Early console
>> - AT24MAC602 EEPROM
>> - MCP2515 SPI to CAN
>> - ADV7535 DSI-to-HDMI bridge
>> - DisplayPort interface
>> - SN65DSI84ZXHR DSI-to-LVDS bridge
>> - Wi-Fi/BT
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Sudarshan Shetty <tessolveupstream@xxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile             |   6 +
>>  arch/arm64/boot/dts/qcom/qcs615-ride.dts      |   4 +-
>>  .../qcom/talos-evk-lvds-auo,g133han01.dtso    | 131 ++++
>>  arch/arm64/boot/dts/qcom/talos-evk-som.dtsi   | 609 ++++++++++++++++++
>>  .../dts/qcom/talos-evk-usb1-peripheral.dtso   |  10 +
>>  arch/arm64/boot/dts/qcom/talos-evk.dts        | 139 ++++
>>  arch/arm64/boot/dts/qcom/talos.dtsi           |   8 +-
>>  7 files changed, 901 insertions(+), 6 deletions(-)
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-lvds-auo,g133han01.dtso
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk-usb1-peripheral.dtso
>>  create mode 100644 arch/arm64/boot/dts/qcom/talos-evk.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index 0ca6b50a6de1..a5f763cf1a55 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -609,7 +609,7 @@ bluetooth {
>>  	};
>>  };
>>  
>> -&usb_hsphy_1 {
>> +&usb_1_hsphy {
>>  	vdd-supply = <&vreg_l5a>;
>>  	vdda-pll-supply = <&vreg_l12a>;
>>  	vdda-phy-dpdm-supply = <&vreg_l13a>;
>> @@ -632,7 +632,7 @@ &usb_1_dwc3 {
>>  	dr_mode = "peripheral";
>>  };
>>  
>> -&usb_hsphy_2 {
>> +&usb_2_hsphy {
>>  	vdd-supply = <&vreg_l5a>;
>>  	vdda-pll-supply = <&vreg_l12a>;
>>  	vdda-phy-dpdm-supply = <&vreg_l13a>;
> 
> Wait... What is going on? This is supposed to be a part of the previous
> patch!
>

Apologies for the oversight. That change was mistakenly split from the previous 
patch during preparation of the series.
Thank you for pointing it out. I have corrected the patch set accordingly and 
will resend the updated version shortly.
 
> 
>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
>> index c7dc507a50b5..cb32bfe732fb 100644
>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
>> @@ -4304,7 +4304,7 @@ osm_l3: interconnect@18321000 {
>>  			#interconnect-cells = <1>;
>>  		};
>>  
>> -		usb_hsphy_1: phy@88e2000 {
>> +		usb_1_hsphy: phy@88e2000 {
>>  			compatible = "qcom,qcs615-qusb2-phy";
>>  			reg = <0x0 0x88e2000 0x0 0x180>;
>>  
>> @@ -4319,7 +4319,7 @@ usb_hsphy_1: phy@88e2000 {
>>  			status = "disabled";
>>  		};
>>  
>> -		usb_hsphy_2: phy@88e3000 {
>> +		usb_2_hsphy: phy@88e3000 {
>>  			compatible = "qcom,qcs615-qusb2-phy";
>>  			reg = <0x0 0x088e3000 0x0 0x180>;
>>  
>> @@ -4412,7 +4412,7 @@ usb_1_dwc3: usb@a600000 {
>>  				iommus = <&apps_smmu 0x140 0x0>;
>>  				interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>>  
>> -				phys = <&usb_hsphy_1>, <&usb_qmpphy>;
>> +				phys = <&usb_1_hsphy>, <&usb_qmpphy>;
>>  				phy-names = "usb2-phy", "usb3-phy";
>>  
>>  				snps,dis-u1-entry-quirk;
>> @@ -4476,7 +4476,7 @@ usb_2_dwc3: usb@a800000 {
>>  				iommus = <&apps_smmu 0xe0 0x0>;
>>  				interrupts = <GIC_SPI 664 IRQ_TYPE_LEVEL_HIGH>;
>>  
>> -				phys = <&usb_hsphy_2>;
>> +				phys = <&usb_2_hsphy>;
>>  				phy-names = "usb2-phy";
>>  
>>  				snps,dis_u2_susphy_quirk;
> 
> ... And this.
>