Re: [PATCH v3 8/8] gpu: nova-core: gsp: use available device reference

From: Danilo Krummrich

Date: Tue Feb 17 2026 - 06:33:15 EST


On Tue Feb 17, 2026 at 3:45 AM CET, Alexandre Courbot wrote:
> We already have a regular reference to the `Device`, so we don't need to
> repeatedly acquire one in this method.
>
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

This conflicts with [1]. I think I will just drop [1] from my queue, since for
nova-core specifically using the base Device here may be better, as eventually
nova-core will work with both a pci::Device and a platform::Device.

(Which also reminds me that at some point we have to treat pci::Bar as generic
I/O backend.)

I hope we can actually keep as many code paths in common as I imagine.

[1] https://lore.kernel.org/all/20260123175854.176735-7-gary@xxxxxxxxxx/