Re: [PATCH v3 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC

[Svyatoslav Ryhel]

17 лютого 2026 р. 13:32:26 GMT+02:00, Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>On 17/02/2026 12:23, Svyatoslav Ryhel wrote:
>>>> in other words you propose this:
>>>>
>>>> properties:
>>>>   compatible:
>>>>     oneOf:
>>>>       - items:
>>>>           - enum:
>>>>               - asus,sl101-ec-dock
>>>>               - asus,tf101-ec-dock
>>>>               - asus,tf101g-ec-dock
>>>>               - asus,tf201-ec-dock
>>>>               - asus,tf300t-ec-dock
>>>>               - asus,tf300tg-ec-dock
>>>>               - asus,tf300tl-ec-dock
>>>>               - asus,tf700t-ec-dock
>>>>           - const: asus,transformer-ec-dock
>>>>
>>>>       - items:
>>>>           - enum:
>>>>               - asus,p1801-t-ec-pad
>>>>               - asus,tf201-ec-pad
>>>>               - asus,tf300t-ec-pad
>>>>               - asus,tf300tg-ec-pad
>>>>               - asus,tf300tl-ec-pad
>>>>               - asus,tf700t-ec-pad
>>>>               - asus,tf600t-ec-pad
>>>>               - asus,tf701t-ec-pad
>>>>           - const: asus,transformer-ec-pad
>>>>
>>>> And in the driver add match to every single entry of enums?
>>>
>>> No, I was talking about removing the generic compatibles entirely, since
>>> they are not suitably generic to cover all devices at the point of
>>> addition. So like:
>>>
>> 
>> Actually, they all can be grouped under asus,transformer-ec fallback if that is needed, both pad and dock EC have the same core functions just different set of cells. And then in the driver each compatible will get a dedicated matching data. Will this work?
>
>Then what does the generic compatible express if it is not used by the SW.
>
>Wrap your emails to mailing list style.
>
>> 
>> properties:
>>   compatible:
>>       - items:
>>           - enum:
>>               - asus,p1801-t-ec-pad
>>               - asus,sl101-ec-dock
>>               - asus,tf101-ec-dock
>>               - asus,tf101g-ec-dock
>>               - asus,tf201-ec-dock
>>               - asus,tf201-ec-pad
>>               - asus,tf300t-ec-dock
>>               - asus,tf300t-ec-pad
>>               - asus,tf300tg-ec-dock
>>               - asus,tf300tg-ec-pad
>>               - asus,tf300tl-ec-dock
>>               - asus,tf300tl-ec-pad
>>               - asus,tf700t-ec-dock
>>               - asus,tf700t-ec-pad
>>               - asus,tf600t-ec-pad
>>               - asus,tf701t-ec-pad
>>           - const: asus,transformer-ec
>> 
>> And them schema name will match the genetic compatible.
>
>Then what does the generic compatible express?
>

Then enum it is

>
>Best regards,
>Krzysztof