Re: [PATCH RFC 5/8] arm64: dts: qcom: Remove inexistent TCSR_CC

From: Krzysztof Kozlowski

Date: Tue Feb 17 2026 - 07:39:53 EST


On 02/02/2026 15:57, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> On SM8750 specifically, the block which provides various reference
> clocks does *NOT* live inside TCSR, but rather TLMM.
>
> With the former now being able to properly expose them, switch over to
> the proper source.
>
> Now, the TCSR still exists as a block for various tunables and
> switches, however the prior misuse resulted in its 8750-specifc
> compatible being already in use. With it freed up, it is now free again
> to be described properly.
>
> Fixes: 068c3d3c83be ("arm64: dts: qcom: Add base SM8750 dtsi")
> Cc: <stable+noautosel@xxxxxxxxxx> # complex dependencies, no immediate gain
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8750.dtsi | 22 ++++++++--------------


This will break all the users of this DTS and commit msg is silent about
this. It's also silent on actual bug being supposedly fixed here.

So again - as explained many times to other Qualcomm engineers - you
cannot just break the users silently and without justified reason.

That's RFC, so maybe you planned to rewrite it later, dunno. That's why
I did not review the rest.

Best regards,
Krzysztof