Re: [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support
From: Vivek Sahu
Date: Tue Feb 17 2026 - 07:51:42 EST
On 2/17/2026 1:23 PM, Krzysztof Kozlowski wrote:
On Tue, Feb 17, 2026 at 01:17:29PM +0530, Vivek Sahu wrote:There is high impact on the existing design if i make this enum sorted. We are considering your comments regarding sorting for next commit not for this commit. Can we have approval for this commit if all other changes looks fine.
As mentioned in the cover letter "qca_btsoc_type" enum in+ case QCA_QCC2072:
+ snprintf(config.fwname, sizeof(config.fwname),
+ "qca/ornnv%02x.bin", rom_ver);
+ break;
case QCA_WCN3950:
if (le32_to_cpu(ver.soc_id) == QCA_WCN3950_SOC_ID_T)
variant = "t";
diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h
index 8f3c1b1c77b3..a175ac31e7b2 100644
--- a/drivers/bluetooth/btqca.h
+++ b/drivers/bluetooth/btqca.h
@@ -158,6 +158,7 @@ enum qca_btsoc_type {
QCA_WCN6750,
QCA_WCN6855,
QCA_WCN7850,
+ QCA_QCC2072,
Why not keep it sorted?
drivers/bluetooth/btqca.h contains all the soc type which need to be enabled
for BT enablement on the target device. There are few places where logic of
framing packets transferring between SoC and Host depends on the which
generation of the chip it is, refer api "qca_read_soc_version". So It is not
sorted in btqca.h file.
Neither in previous patch comments nor here you respond to actual
comment. You just write something completely irrelevant.
I don't think any of this should be considered if you are not
responding to actual comments.
Best regards,
Krzysztof