Re: [PATCH] arm64: dts: ti: k3-am62a7-sk: Disable mmc Schmitt Trigger

[Sverdlin, Alexander]

On Tue, 2026-02-17 at 13:57 +0100, Alexander Sverdlin wrote:
> > > > > > Can you please run a quick tap sweep on MMC1 and MMC0 interfaces like
> > > > > > so? https://gist.github.com/jmenti/f4a73a8323e44bf717c6d2c528c499ca
> > > > > > 
> > > > > > This will give me an idea if whether we should be talking about
> > > > > > revisiting characterization with ST_ENA=1.
> 
> I wanted to apply your patch and test on our HW, but I have some doubts, if
> the patch maybe missing something:
> 
> - am654_sdhci_write_otapdly() turns out to be unused in any upstream U-Boot version
> - new "omap" variable in am654_sdhci_execute_tuning() is in fact unused as well

and

| /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c: In function 'j721e_4bit_sdhci_set_ios_post':
| /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c:598:9: error: 'itap_del_sel' is used uninitialized [-Werror=uninitialized]
|   598 |         printf("j721e_4bit_sdhci_set_ios_post, mode=%d, otap=%d, itap=%d\n", mode, otap_del_sel, itap_del_sel);
|       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| /home/sverdlin/u-boot/drivers/mmc/am654_sdhci.c:594:13: note: 'itap_del_sel' was declared here
|   594 |         u32 itap_del_sel;
|       |             ^~~~~~~~~~~~


so I'm not sure regarding the previous test results at all any longer...

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com