Re: [PATCH net] bnge: Fix typo

[Vikas Gupta]

Hi Simon,

On Tue, Feb 17, 2026 at 9:26 PM Simon Horman <horms@xxxxxxxxxx> wrote:
>
> On Mon, Feb 16, 2026 at 07:32:35PM +0530, Vikas Gupta wrote:
> > Fix the HWRM command type and use the appropriate command to reserve
> > the resources.
> >
> > Fixes: 627c67f038d2 ("bng_en: Add resource management support")
> > Signed-off-by: Vikas Gupta <vikas.gupta@xxxxxxxxxxxx>
> > Reviewed-by: Bhargava Chenna Marreddy <bhargava.marreddy@xxxxxxxxxxxx>
>
> Hi,
>
> I think this patch could do with a little more explanation.
> It's not clear to me, at least: what the difference is between
> HWRM_FUNC_QCFG and HWRM_FUNC_CFG; and why only one of
> the instances added by the cited patch needs updating.

HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is intended
for querying resource information from the firmware.
Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific
PF, the command type
should be HWRM_FUNC_CFG.
However, HWRM_FUNC_QCFG was mistakenly used instead.
Does it clarify?

Thanks,
Vikas

>
> ...

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature