Re: [PATCH v5 000/144] smb: smbdirect/client/server: moving to common functions and smbdirect.ko

[Steve French]

On Tue, Feb 17, 2026 at 3:25 AM Stefan Metzmacher <metze@xxxxxxxxx> wrote:
>
> Am 17.02.26 um 03:16 schrieb Steve French:
> > I noticed build warnings on two files when I build with your updated
> > branch. See below:
> >
> >    CHECK   client/smbdirect.c
> > client/smbdirect.c:97:1: error: bad integer constant expression
> > client/smbdirect.c:97:1: error: static assertion failed:
> > "MODULE_INFO(parmtype, ...) contains embedded NUL byte"
> > client/smbdirect.c:98:1: error: bad integer constant expression
> > client/smbdirect.c:98:1: error: static assertion failed:
> > "MODULE_INFO(parm, ...) contains embedded NUL byte"
> > client/smbdirect.c:104:1: error: bad integer constant expression
> > client/smbdirect.c:104:1: error: static assertion failed:
> > "MODULE_INFO(parmtype, ...) contains embedded NUL byte"
> > client/smbdirect.c:105:1: error: bad integer constant expression
> > client/smbdirect.c:105:1: error: static assertion failed:
> > "MODULE_INFO(parm, ...) contains embedded NUL byte"
> >    CC [M]  server/server.o
> >    CHECK   server/server.c
> > server/server.c:629:1: error: bad integer constant expression
> > server/server.c:629:1: error: static assertion failed:
> > "MODULE_INFO(author, ...) contains embedded NUL byte"
> > server/server.c:630:1: error: bad integer constant expression
> > server/server.c:630:1: error: static assertion failed:
> > "MODULE_INFO(description, ...) contains embedded NUL byte"
> > server/server.c:631:1: error: bad integer constant expression
> > server/server.c:631:1: error: static assertion failed:
> > "MODULE_INFO(license, ...) contains embedded NUL byte"
> > server/server.c:632:1: error: bad integer constant expression
> > server/server.c:632:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:633:1: error: bad integer constant expression
> > server/server.c:633:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:634:1: error: bad integer constant expression
> > server/server.c:634:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:635:1: error: bad integer constant expression
> > server/server.c:635:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:636:1: error: bad integer constant expression
> > server/server.c:636:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:637:1: error: bad integer constant expression
> > server/server.c:637:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
> > server/server.c:638:1: error: bad integer constant expression
> > server/server.c:638:1: error: static assertion failed:
> > "MODULE_INFO(softdep, ...) contains embedded NUL byte"
>
> I didn't change any MODULE_INFO() code, I guess it also happens
> without my patches?
>
> I saw something similar with MODULE_LICENSE and maybe MODULE_DESCRIPTION
> in the 6.19 merge windows.
>
> And it was a bug in sparse.
>
> I updated the version I use to this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/sparse.git/commit/?id=2634e39bf02697a18fece057208150362c985992
> which is one above https://git.kernel.org/pub/scm/devel/sparse/sparse.git/

Good catch - you were right it is a bug in sparse tool, not something
you changed (I had to upgrade sparse since it wasn't getting run for
the last few days due to requiring an upgrade).   I added the fix from
Al which fixed the incorrect warning.


-- 
Thanks,

Steve