Re: [PATCH v2 0/6] platform-x86: lenovo-wmi: Add fixes and enhancement

[Mark Pearson]

On Sun, Feb 15, 2026, at 1:12 AM, Derek J. Clark wrote:
> This series adds many much needed features and fixes to the lenovo-wmi
> drivers.
>
> Patch 1 adds a macro to make assigning attribute ID's for capdata
> cleaner and easier.
> Patch 2 addresses bugs where devices that don't support exposed
> attributes would still create the attribute, and also attempts to
> identify the correct capdata and set/get methods as some legacy
> interfaces don't use the custom mode in the method or capdata ID.
> Patch 3 adds the remaining CPU attributes that weren't previously
> exposed.
> Patch 4 adds the GPU attributes that weren't previously exposed.
> Patch 5 consolidates name constants in preparation for patch 6.
> Patch 6 adds battery charge-type limiting when supported only by WMI.
>
> After applying Rong's series from
> https://lore.kernel.org/platform-driver-x86/20260210191938.137234-1-i@xxxxxxxx/
> I found that there weren't any conflicts, so rather than combine
> the series we can just review each separately.
>
> Signed-off-by: Derek J. Clark <derekjohn.clark@xxxxxxxxx>
> ---
> v2:
>  - Fix gpu_mode misisng from attributes list.
>  - Fix prototypes for power suppy patch.
>  - Reorganize CPU and GPU attributes alphabetically.
>  - Break out the patch consolidating the driver name cost.
>  - Move some of the refactoring of attribute_id back to into patch 1
>    where it belongs.
>  - Fix some additional typos in function prototypes.
> v1: 
> https://lore.kernel.org/platform-driver-x86/20260213081243.794288-1-derekjohn.clark@xxxxxxxxx/
>
> Derek J. Clark (6):
>   platform/x86: lenovo-wmi-other: Add LWMI_ATTR_ID Macro
>   platform/x86: lenovo-wmi-other: Limit adding attributes to supported
>     devices
>   platform/x86: lenovo-wmi-other: Add missing CPU tunable attributes
>   platform/x86: lenovo-wmi-other: Add GPU tunable attributes
>   platform-x86: lenovo-wmi-other: Consolidate name into single const
>   platform/x86: lenovo-wmi-other: Add WMI battery charge limiting.
>
>  .../wmi/devices/lenovo-wmi-other.rst          |  21 +
>  drivers/platform/x86/lenovo/wmi-capdata.h     |  13 +-
>  drivers/platform/x86/lenovo/wmi-gamezone.h    |   1 +
>  drivers/platform/x86/lenovo/wmi-other.c       | 606 ++++++++++++++++--
>  4 files changed, 592 insertions(+), 49 deletions(-)
>
>
> base-commit: 5a5203a45b063a594e89a2aeaf9e4923893a5b4c
> -- 
> 2.52.0

For the series - looked good to me (I didn't know the hwmon limitation Kurt highlighted)
Reviewed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
Mark