Re: [PATCH v4 0/9] iio: light: gp2ap020a00f: General cleanup and

[Andy Shevchenko]

On Tue, Feb 17, 2026 at 10:37:19PM -0600, Ethan Tidmore wrote:
> This series performs a general cleanup of the gp2ap020a00f IIO driver.
> 
> It integrates my original work switching to the guard() cleanup handler,
> fixing a signedness warning from Smatch, and cleanups provided by
> Andy Shevchenko [1].

Thanks, my comments below and in patch 1/9.

> v4:
>  - Integrated Andy Shevchenko's 7-patch cleanup series.
>  - Patch 1: Removed redundant 'err' variable and whitespace issues as
>    suggested by Andy.
>  - Patch 2: Added Reviewed-by tag from Andy Shevchenko.

>  - Patch 5: Updated commit message to describe the pre-existing bug fix
>    in gp2ap020a00f_buffer_predisable() where errors could be swallowed.

As I mentioned this perhaps better to split to a separate change as
a prerequisite to the mentioned patch.

> v3:
>  - Addressed initial feedback and simplified locking logic.
> 
> [1] https://lore.kernel.org/all/20260217102318.1354103-1-andriy.shevchenko@xxxxxxxxxxxxxxx/
> 
> Andy Shevchenko (7):
>   iio: light: gp2ap020a00f: Use correct types for 16-bit LE data
>   iio: light: gp2ap020a00f: Replace custom implementation of min()
>   iio: light: gp2ap020a00f: Return directly from the switch cases
>   iio: light: gp2ap020a00f: Use temporary variable for struct device
>   iio: light: gp2ap020a00f: Explicitly use string literal for driver
>     name
>   iio: light: gp2ap020a00f: Remove trailing comma in termination entry
>   iio: light: gp2ap020a00f: Join some lines of code to be a single line

-- 
With Best Regards,
Andy Shevchenko