Re: [PATCH] ALSA: hda/realtek: Fix speaker pop on Star Labs

[Takashi Iwai]

On Wed, 18 Feb 2026 09:18:42 +0100,
Sean Rhodes wrote:
> 
> From a673e45b345d494b7ec7143a8ace72faf6aa85f1 Mon Sep 17 00:00:00 2001
> From: Sean Rhodes <sean@starlabs.systems>
> Date: Tue, 17 Feb 2026 11:53:41 +0000
> Subject: [PATCH v2] ALSA: hda/realtek: Fix speaker pop on Star Labs
>  StarFighter
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: tiwai@xxxxxxxx,
>     perex@xxxxxxxx,
>     sbinding@xxxxxxxxxxxxxxxxxxxxx,
>     kailang@xxxxxxxxxxx,
>     chris.chiu@xxxxxxxxxxxxx,
>     edip@xxxxxxxxx,
>     david.henningsson@xxxxxxxxxxxxx,
>     linux-sound@xxxxxxxxxxxxxxx

Those lines appear in the patch description by some reason.
I guess your mailer put it wrongly...

> On Star Labs StarFighter (Realtek ALC233/235), the internal speakers can
> emit an audible pop when entering or leaving runtime suspend.
> 
> The default Realtek shutup path powers down the codec by toggling EAPD and
> adjusting pin widget control. When the speaker path is still unmuted, this
> can lead to a pop.
> 
> Mute the speaker output paths via snd_hda_gen_shutup_speakers() before
> running the normal Realtek shutup path.

Actually, with this setup, any other shutup function is called.
That is, solely muting the outputs suffices for your machine.

> Test results: fixes the runtime PM suspend/resume speaker pop.
> Pops that can occur on cold boot (G3 exit) and around display manager
> start/shutdown are not addressed.

The cold boot might be harder to tackle, but I wonder how the display
manager start/shutdown causes the pop noise.  Does it mean a runtime
resume causes the pop noise, too?


Takashi