Re: [PATCH 4/4] arm64: dts: qcom: add device tree for SDM845-HDK

[Konrad Dybcio]

On 2/17/26 10:20 PM, Dmitry Baryshkov wrote:
> Add device tree for the Qualcomm / Lantronix SDM845 HDK. It is the
> development platform using the modem-less (SDA845) SoC, optional onboard
> DSI panel and a rich set of connectors.
> 
> Working:
> - HDMI display
> - uSD, UFS, USB
> - DSPs, WiFi, BT
> - Buttons, LEDs
> 
> Not working or not tested:
> - DisplayPort - TCPM not supported for this PMIC
> - WiGig - requires power sequencing driver, doesn't work with the
>   current in-kernel driver
> - Audio
> - FingerPrint
> - USIM
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

[...]

> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		autorepeat;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&home_pin_a>, <&vol_up_pin_a>;

property-n
property-names

in this order, file-wide, please

[...]

> +&cluster_sleep_0 {
> +	/* default, 0x4100c244, kills the board */
> +	arm,psci-suspend-param = <0x41008244>;
> +};

Does crashdump say anything interesting?

[...]

> +&mdss_dsi1_phy {
> +	vdds-supply = <&vreg_s6a_0p8>;
> +	status = "okay";

Let's uniformly keep a \n above 'status'

[...]

> +&pm8998_gpios {
> +	home_pin_a: home-active-state {
> +		pins = "gpio6";

gpio5 here

[...]

> +&pmi8998_lpg {
> +	status = "okay";
> +
> +	qcom,power-source = <1>;
> +
> +	led@3 {
> +		reg = <3>;
> +		color = <LED_COLOR_ID_BLUE>;
> +		function = LED_FUNCTION_BLUETOOTH;
> +		linux,default-trigger = "bluetooth-power";
> +	};
> +
> +	led@4 {
> +		reg = <4>;
> +		color = <LED_COLOR_ID_GREEN>;
> +		function = LED_FUNCTION_HEARTBEAT;
> +		linux,default-trigger = "heartbeat";
> +		function-enumerator = <2>;

function-enumerators only seem necessary when the same color&func
combo is registered multiple times

> +	};
> +
> +	led@5 {
> +		reg = <5>;
> +		color = <LED_COLOR_ID_RED>;
> +		function = LED_FUNCTION_INDICATOR;
> +		function-enumerator = <1>;

panic-indicator?

> +	};
> +};
> +
> +&pmi8998_wled {
> +	status = "disabled";
> +};

It's already disabled

> +
> +&qupv3_id_0 {
> +	status = "okay";
> +};
> +
> +&qupv3_id_1 {
> +	status = "okay";
> +};
> +
> +&sdhc_2 {
> +	status = "okay";

last, please (there's more occurences below)


> +	pcie0_default_state: pcie0-default-state {
> +		clkreq-pins {
> +			pins = "gpio36";
> +			function = "pci_e0";
> +			bias-pull-up;
> +		};
> +
> +		perst-n-pins {
> +			pins = "gpio35";
> +			function = "gpio";
> +			drive-strength = <2>;
> +			bias-pull-down;

bias-disable?

Konrad