Re: [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset
From: Richard Fitzgerald
Date: Wed Feb 18 2026 - 06:02:50 EST
On 18/2/26 10:50, Pierre-Louis Bossart wrote:
On 2/18/26 11:14, Richard Fitzgerald wrote:Oh, does it date all the way back to that multiple device problem?
On 17/2/26 23:35, Cole Leavitt wrote:
On systems with CS35L56 SoundWire codecs (e.g. Lenovo ThinkPad P16
Gen3), every boot produces misleading dev_warn() messages:
cs35l56 sdw:0:2:01fa:3556:01:0: Slave 2 state check1: UNATTACHED, status was 1
cs35l56 sdw:0:2:01fa:3556:01:1: Slave 1 state check1: UNATTACHED, status was 1
Is this really a problem?
They are warns, not errors. Nothing in that message says that this is
an error, or that it's unexpected. The message is accurate.
I would just demote the dev_warn() to dev_dbg().
If you look at the original commit, we were chasing weird cases where we have dyndng enabled anyways.
Also IIRC the problem with 2 devices on the same link was fixed by Richard, wasn't it?
That would make the dev_warn() even less useful.
If that's the one I'm thinking of, as I recall it was Simon Trimmer
who fixed that.