Re: [PATCH v6] crypto: qce - Add runtime PM and interconnect bandwidth scaling support

[Konrad Dybcio]

On 2/18/26 7:02 AM, Udit Tiwari wrote:
> Hi Konrad,
> 
> Thanks for pointing this out.
> 
> I agree with your points regarding the usage of the ACQUIRE guard in probe to simplify the error paths, as well as the redundancy of icc_enable in the resume path. I will address both in the next version.
> 
> While preparing the fix, I performed a self-review and noticed a potential issue. Since I am providing my own custom functions for runtime suspend/resume (to handle the ICC path), the standard clock helpers are no longer called automatically by the PM framework.
> 
> I believe I need to manually call pm_clk_resume(dev) and pm_clk_suspend(dev) inside my custom functions to ensure the clocks are actually gated and ungated.
> 
> Does this look correct to you? If you agree, I will include this fix in v7.

I tried to find an answer, but it seems like one of these situations where
it's easier to add some debug prints than to analyze the code ;)

Konrad