Re: [PATCH RFC 1/2] dt-bindings: pinctrl: Add pinctrl-packed

[Billy Tsai]

Hi Krzysztof,

Thanks for the detailed review.
You are right regarding the example – it is not valid and would
trigger schema warnings. I should have tested it more thoroughly.
I will improve my testing workflow for future bindings.
Before sending the next revision, I will run:

    make dt_binding_check

without constraining the schema selection, and ensure that no new
warnings are introduced by the patches.

However, based on further feedback from Linus,
I will change direction and drop the generic "pinctrl-packed" binding.
Instead, I will implement an AST2700-specific driver using static SoC
data and reuse the existing standard pinmux and pin configuration
bindings. This should address your concern about the binding being
too generic and introducing unnecessary custom properties.

Hi Linus,

Based on your feedback perhaps introducing a new generic
"pinctrl-packed" binding is not justified at this stage.

Instead, I plan to:

- Drop the generic pinctrl-packed binding.
- The implementation primarily comes down to
describing the pin-to-register-field ordering and the
value-to-function mapping in static SoC data and the rest of
the driver will rely on the generic pinctrl APIs/existing pinctrl-packed code.
- Name the driver "pinctrl-aspeed-ast2700-soc1".
- Reuse the existing standard pinmux and pin configuration
  bindings (pinmux-node.yaml and pincfg-node.yaml),
  without introducing any custom DT properties.
- Hard-code the function mask and field width in the driver,
since they are fixed by the AST2700 hardware

Thanks
Best regards,
Billy Tsai