Re: [PATCH v2 net] net: dsa: sja1105: protect link replay helpers against NULL phylink instance

[Vladimir Oltean]

On Wed, Feb 18, 2026 at 04:21:53PM +0000, Russell King (Oracle) wrote:
> > > > v1->v2: select option 1 instead of 2
> > > 
> > > Given this, I think the paragraph above needs updating.
> > 
> > Sorry, I don't understand what needs updating.
> 
> Oh, you rearranged the options, which makes this changelog comment
> wrong. You're still going with option 1, but you've swapped what was
> option 1 and option 2.
> 
> So, the changelog comment should be:
> 
> v1->v2: implement option 2 in the original submission, swapping their
>   order so it becomes option 1.
> 
> since "select option 1 instead of 2" is ambiguous (obviously) because
> it doesn't state whether these refer to the initial patch or this
> patch. I assumed they were referring to the options on this patch,
> that the options hadn't changed, and thus "So, I went with option 1"
> was an error.

I didn't rearrange the options... They are still the same in v1 as well.
Why would have Andrew said "I prefer option 1", and you as well?
https://lore.kernel.org/netdev/877b4780-9f99-478c-82fa-a32817d72004@xxxxxxx/