Re: [PATCH 6/7] arm64: dts: amlogic: Add clock and EMMC for T7

[Ronald Claveau]

On 2/18/26 11:23 AM, Krzysztof Kozlowski wrote:
> On 18/02/2026 11:20, Ronald Claveau wrote:
>> Add fixed clock and EMMC support for Amlogic T7 SoC family dtsi.
>>
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@xxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 137 +++++++++++++++++++-
>>  1 file changed, 134 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> index 6510068bcff9..e5932eb3db2b 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>> @@ -3,6 +3,8 @@
>>   * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>>   */
>>  
>> +#include <dt-bindings/clock/amlogic,t7-peripherals-clkc.h>
>> +#include <dt-bindings/clock/amlogic,t7-pll-clkc.h>
>>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>>  #include <dt-bindings/power/amlogic,t7-pwrc.h>
>>  #include "amlogic-t7-reset.h"
>> @@ -208,12 +210,14 @@ soc {
>>  		ranges;
>>  
>>  		gic: interrupt-controller@fff01000 {
>> -			compatible = "arm,gic-400";
>> +			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";
> 
> I don't get how this is related to "Add fixed clock".
> 
>>  			#interrupt-cells = <3>;
>>  			#address-cells = <0>;
>>  			interrupt-controller;
>>  			reg = <0x0 0xfff01000 0 0x1000>,
>> -			      <0x0 0xfff02000 0 0x0100>;
>> +				  <0x0 0xfff02000 0 0x2000>,
>> +				  <0x0 0xfff04000 0 0x2000>,
>> +				  <0x0 0xfff06000 0 0x2000>;
> 
> Neither this really.
> 
> ...
> 

You right, I will send a different patch to address that specific issue,
and I will remove it here for v2.

>> +
>> +			sd_emmc_c: mmc@8c000{
>> +				compatible = "amlogic,meson-axg-mmc";
> 
> Compatible says axg, DTS says T7, so something does not feel right.
> 

The SOC family is T7, but the emmc is fully compatible with this same
axg code.
I did the same as used in meson-g12-common.dtsi or meson-s4.dtsi, which
use the same compatible.

Best Regards,
Ronald