Re: [PATCH] stop_machine: Fix the documentation for a NULL cpus argument

From: Paul E. McKenney

Date: Wed Feb 18 2026 - 13:08:35 EST


On Wed, Feb 18, 2026 at 08:26:11AM +0100, Sebastian Andrzej Siewior wrote:
> On 2026-02-17 09:01:11 [-0800], Paul E. McKenney wrote:
> > On Tue, Feb 17, 2026 at 05:31:05PM +0100, Sebastian Andrzej Siewior wrote:
> > > On 2026-02-17 14:11:11 [+0100], Thomas Weißschuh wrote:
> > > > A recent refactoring of the kernel-docs for stop machine changed the
> > > > description of the cpus parameter from "NULL = any online cpu"
> > > > to "NULL = run on each online CPU".
> > > >
> > > > However the callback is only executed on a single CPU, not all of them.
> > > > The old wording was a bit ambiguous and could have been read both ways.
> > > >
> > > > Reword the documentation to be correct again and hopefully also clearer.
> > >
> > > It is the first online CPU.
> >
> > Do we want to set that in stone?
>
> then keep it as is. I somehow don't like the wording but I'm not here
> for bike shedding.

I agree that it probably could be improved, but it does seem clear,
correct, and unambiguous, so I also agree with leaving good enough
alone. ;-)

> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Applied and pushed, thank you!

Thanx, Paul