Re: [PATCH] rust: pin-init: replace clippy `expect` with `allow`

[Benno Lossin]

On Wed Feb 18, 2026 at 4:08 PM CET, Gary Guo wrote:
> On 2026-02-16 11:17, Benno Lossin wrote:
>> On Mon Feb 16, 2026 at 2:36 AM CET, Gary Guo wrote:
>>> On 2026-02-15 13:22, Benno Lossin wrote:
>>>> `clippy` has changed behavior in [1] (Rust 1.95) where it no longer
>>>> warns about the `let_and_return` lint when a comment is placed 
>>>> between
>>>> the let binding and the return expression. Nightly thus fails to 
>>>> build,
>>>> because the expectation is no longer fulfilled.
>>>> 
>>>> Thus replace the expectation with an `allow`.
>>>> 
>>>> Link: https://github.com/rust-lang/rust-clippy/pull/16461 [1]
>>>> Signed-off-by: Benno Lossin <lossin@xxxxxxxxxx>
>>> 
>>> I think it's worth adding a comment (or reason) that this is no longer 
>>> needed after 1.95.
>> 
>> We'll remove the let binding when we raise the MSRV above 1.78 and then
>> the `allow` should also be gone. Do you still want me to add it?
>> 
>> Cheers,
>> Benno
>
> The existing comment just says that the bug exists in 1.78. So is it 
> fixed in 1.79+? If so,
> please update the comment to say the MSRV that this is no longer needed, 
> then I'm fine
> without reason for clippy allow.

We discussed this in the meeting, Miguel will pick this patch as-is and
I'll send a follow up to change the comment.

Cheers,
Benno