Re: [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static

[Badhri Jagan Sridharan]

On Wed, Feb 18, 2026 at 1:19 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Feb 18, 2026 at 01:02:50PM -0800, Badhri Jagan Sridharan wrote:
> > On Wed, Feb 18, 2026 at 12:56 PM Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > On Wed, Feb 18, 2026 at 12:35:04PM -0800, Badhri Jagan Sridharan wrote:
> > > > On Mon, Feb 16, 2026 at 3:04 AM Krzysztof Kozlowski
> > > > <krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
> > > > >
> > > > > File-scope 'tcpci_pm_ops' is not used outside of this unit, so make it
> > > > > static to silence sparse warning:
> > > > >
> > > > >   tcpm/tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static?
> > > > >
> > > >
> > > > Thanks for sending the patch Krzysztof !
> > > > Can you also please add "Fixes:" and "Cc: stable@xxxxxxxxxxxxxxx" ?
> > >
> > > Why would a sparse warning fix need either of those?  Are you wanting to
> > > just pre-load my "WTF" email bot to go off?  :)
> >
> > I am still learning :) Wasn't aware that warning fixes are not
> > supposed to have those.
>
> This is a warning from sparse, not the build.  sparse is an add-on
> thing, not a part of a normal kernel build.

Thanks Greg for the additional context. I will keep this in mind in the future!

>
> thanks,
>
> greg k-h