Re: [PATCH v1 2/2] ASoC: Intel: soc-acpi-cht: Add Lenovo Yoga Book entries

[Yauhen Kharuzhy]

On Wed, Feb 18, 2026 at 11:35:12AM +0100, Pierre-Louis Bossart wrote:
> On 2/18/26 00:13, Yauhen Kharuzhy wrote:
> > Lenovo Yoga Book YB1-X91 device uses a Cherry Trail SoC and has a valid
> > ACPI DSDT entry for the RT5677 codec. This entry has some non-standard
> > resource definitions, such as jack detection chip information, and
> > hardware has some additional GPIO controls so use 'cht-yogabook'
> > for the driver name instead of some default (like 'cht-bsw-rt5677').
> > 
> > Lenovo Yoga Book YB1-X90 device (Android version of the tablet) has the
> > same hardware configuration but lacks a valid ACPI DSDT entry for the
> > codec. To match this device, extend the existing quirk designated for the
> > Lenovo Yoga Tab 3 Pro YT3-X90 and make it more generic: select a matched
> > machine using the dmi_check_system() quirk mechanism.
> > 
> > Signed-off-by: Yauhen Kharuzhy <jekhor@xxxxxxxxx>
> 
> Looks ok to me, but since this is touching 10-yr old stuff maybe it's worth having a patch that only merged the existing quirks together.
> Then you can add a new set of entries. Easier to review/test/bisect.

Agree, that sounds reasonable.

What about the driver naming? In this patch, I used 'cht-bsw-rt5677' as
the default driver name, but this driver doesn't exist (and I doubt it
ever will in the future). Should we use this 'template' approach, or
add a 'cht-yogabook' driver entry only, or rename 'cht-yogabook' to the
generic 'cht-bsw-rt5677'?


-- 
Yauhen Kharuzhy