Re: [PATCH 1/5] arm64: dts: qcom: msm8996: Drop redundant VSYNC pin state

[Dmitry Baryshkov]

On Thu, Feb 19, 2026 at 08:23:45AM +0100, Krzysztof Kozlowski wrote:
> On 19/02/2026 07:49, Dmitry Baryshkov wrote:
> > On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
> >> The active and suspend pin state of VSYNC is exactly the same, so just
> >> use one node for both states.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> >> ---
> >>  arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi   |  9 +--------
> >>  arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi    | 11 ++---------
> >>  arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts     |  2 +-
> >>  arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts |  2 +-
> >>  4 files changed, 5 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> index 63ab564655bc..a4dcc88bb01f 100644
> >> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
> >>  		bias-pull-down;
> >>  	};
> >>  
> >> -	mdss_te_active: mdss-te-active-state {
> >> -		pins = "gpio10";
> >> -		function = "mdp_vsync";
> >> -		drive-strength = <2>;
> >> -		bias-pull-down;
> >> -	};
> >> -
> >> -	mdss_te_suspend: mdss-te-suspend-state {
> >> +	mdss_te: mdss-te-state {
> > 
> > This is not used and probably can be dropped.
> > 
> 
> But I think it should be used - it's just incomplete. There DSI is
> enabled so there should be a panel using the TE/VSYNC. This looks like
> being added for future, just like many other pincfg states.


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>



-- 
With best wishes
Dmitry