Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle
From: Neeraj Soni
Date: Thu Feb 19 2026 - 03:09:58 EST
On 2/19/2026 12:50 PM, Krzysztof Kozlowski wrote:
> On 19/02/2026 06:38, Neeraj Soni wrote:
>>>> + qcom,ice:
>>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>>> + description:
>>>> + phandle to the Inline Crypto Engine (ICE) hardware block for this controller.
>>>
>>>
>>> Srsly, I asked once and not much improved. What is explicitly written in
>>> coding style which I asked you twice to read?
>>>
>> I have attempted to modifiy it as per the comment you gave in v3 here:
>> https://lore.kernel.org/all/b6e510da-b369-4c43-b9a1-455478af4948@xxxxxxxxxx/
>>
>> I will rephrase it to explain the usage better in next patch.
>>
>>> And how long is this line? Why such trivialities cannot be fixed and I
>>> need to remind this every time?
>>>
>> It is 83 character long but i understand now you expect it to be wrapped
>> at 75 as per kernel coding style. I missed it and stuck to the limit
>
> 75?
>
Apologies for typo. Wanted to right 80:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html
>
>
> Best regards,
> Krzysztof
>