Re: [PATCH 6/8] dmaengine: tegra: Use iommu-map for stream ID
From: Dan Carpenter
Date: Thu Feb 19 2026 - 03:28:57 EST
Hi Akhil,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Akhil-R/dt-bindings-dma-nvidia-tegra186-gpc-dma-Add-iommu-map-property/20260218-014114
base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
patch link: https://lore.kernel.org/r/20260217173457.18628-7-akhilrajeev%40nvidia.com
patch subject: [PATCH 6/8] dmaengine: tegra: Use iommu-map for stream ID
config: sparc64-randconfig-r072-20260218 (https://download.01.org/0day-ci/archive/20260218/202602181757.Amx49qCP-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 10.5.0
smatch version: v0.5.0-8994-gd50c5a4c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202602181757.Amx49qCP-lkp@xxxxxxxxx/
smatch warnings:
drivers/dma/tegra186-gpc-dma.c:1543 tegra_dma_probe() warn: missing error code 'ret'
vim +/ret +1543 drivers/dma/tegra186-gpc-dma.c
ee17028009d49f Akhil R 2022-02-25 1514 tdma->dma_dev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
ee17028009d49f Akhil R 2022-02-25 1515
ee17028009d49f Akhil R 2022-02-25 1516 ret = dma_async_device_register(&tdma->dma_dev);
ee17028009d49f Akhil R 2022-02-25 1517 if (ret < 0) {
ee17028009d49f Akhil R 2022-02-25 1518 dev_err_probe(&pdev->dev, ret,
ee17028009d49f Akhil R 2022-02-25 1519 "GPC DMA driver registration failed\n");
ee17028009d49f Akhil R 2022-02-25 1520 return ret;
ee17028009d49f Akhil R 2022-02-25 1521 }
ee17028009d49f Akhil R 2022-02-25 1522
43f59d3fa0deca Akhil R 2026-02-17 1523 list_for_each_entry(chan, &tdma->dma_dev.channels, device_node) {
43f59d3fa0deca Akhil R 2026-02-17 1524 struct device *chdev = &chan->dev->device;
43f59d3fa0deca Akhil R 2026-02-17 1525
43f59d3fa0deca Akhil R 2026-02-17 1526 tdc = to_tegra_dma_chan(chan);
43f59d3fa0deca Akhil R 2026-02-17 1527 if (use_iommu_map) {
43f59d3fa0deca Akhil R 2026-02-17 1528 chdev->coherent_dma_mask = pdev->dev.coherent_dma_mask;
43f59d3fa0deca Akhil R 2026-02-17 1529 chdev->dma_mask = &chdev->coherent_dma_mask;
43f59d3fa0deca Akhil R 2026-02-17 1530 chdev->bus = pdev->dev.bus;
43f59d3fa0deca Akhil R 2026-02-17 1531
43f59d3fa0deca Akhil R 2026-02-17 1532 ret = of_dma_configure_id(chdev, pdev->dev.of_node,
43f59d3fa0deca Akhil R 2026-02-17 1533 true, &tdc->id);
43f59d3fa0deca Akhil R 2026-02-17 1534 if (ret) {
43f59d3fa0deca Akhil R 2026-02-17 1535 dev_err(chdev, "Failed to configure IOMMU for channel %d: %d\n",
43f59d3fa0deca Akhil R 2026-02-17 1536 tdc->id, ret);
43f59d3fa0deca Akhil R 2026-02-17 1537 goto err_unregister;
43f59d3fa0deca Akhil R 2026-02-17 1538 }
43f59d3fa0deca Akhil R 2026-02-17 1539
43f59d3fa0deca Akhil R 2026-02-17 1540 if (!tegra_dev_iommu_get_stream_id(chdev, &stream_id)) {
43f59d3fa0deca Akhil R 2026-02-17 1541 dev_err(chdev, "Failed to get stream ID for channel %d\n",
43f59d3fa0deca Akhil R 2026-02-17 1542 tdc->id);
43f59d3fa0deca Akhil R 2026-02-17 @1543 goto err_unregister;
ret = -EINVAL;
43f59d3fa0deca Akhil R 2026-02-17 1544 }
43f59d3fa0deca Akhil R 2026-02-17 1545
43f59d3fa0deca Akhil R 2026-02-17 1546 chan->dev->chan_dma_dev = true;
43f59d3fa0deca Akhil R 2026-02-17 1547 }
43f59d3fa0deca Akhil R 2026-02-17 1548
43f59d3fa0deca Akhil R 2026-02-17 1549 /* program stream-id for this channel */
43f59d3fa0deca Akhil R 2026-02-17 1550 tegra_dma_program_sid(tdc, stream_id);
43f59d3fa0deca Akhil R 2026-02-17 1551 tdc->stream_id = stream_id;
43f59d3fa0deca Akhil R 2026-02-17 1552 }
43f59d3fa0deca Akhil R 2026-02-17 1553
ee17028009d49f Akhil R 2022-02-25 1554 ret = of_dma_controller_register(pdev->dev.of_node,
ee17028009d49f Akhil R 2022-02-25 1555 tegra_dma_of_xlate, tdma);
ee17028009d49f Akhil R 2022-02-25 1556 if (ret < 0) {
ee17028009d49f Akhil R 2022-02-25 1557 dev_err_probe(&pdev->dev, ret,
ee17028009d49f Akhil R 2022-02-25 1558 "GPC DMA OF registration failed\n");
43f59d3fa0deca Akhil R 2026-02-17 1559 goto err_unregister;
ee17028009d49f Akhil R 2022-02-25 1560 }
ee17028009d49f Akhil R 2022-02-25 1561
43f59d3fa0deca Akhil R 2026-02-17 1562 dev_info(&pdev->dev, "GPC DMA driver registered %lu channels\n",
3a0c95b61385f5 Akhil R 2022-11-10 1563 hweight_long(tdma->chan_mask));
ee17028009d49f Akhil R 2022-02-25 1564
ee17028009d49f Akhil R 2022-02-25 1565 return 0;
43f59d3fa0deca Akhil R 2026-02-17 1566
43f59d3fa0deca Akhil R 2026-02-17 1567 err_unregister:
43f59d3fa0deca Akhil R 2026-02-17 1568 dma_async_device_unregister(&tdma->dma_dev);
43f59d3fa0deca Akhil R 2026-02-17 1569 return ret;
ee17028009d49f Akhil R 2022-02-25 1570 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki