Re: [RFC PATCH v2 0/2] sysctl: refactor ctl_table creation and change extra{1,2} type

[Joel Granados]

Hey Wen

Sorry for taking so long to come back to you and thx taking this on.

On Sun, Feb 08, 2026 at 04:35:15AM +0800, wen.yang@xxxxxxxxx wrote:
> From: Wen Yang <wen.yang@xxxxxxxxx>
> 
> This series introduces macros to centralize ctl_table initialization,
> preparing for future type changes to extra1/extra2 fields.

Remember to include that the main motivations here is to avoid treewide
patch series. These usually touch lots of subsystem, requires the
attention of many maintainers and sometimes needs to be Pulled to
mainline in a special way. They create lots of unnecessary churn.

Defining the motivation in the cover letter is key to get ppl to
understand why you are doing what you are doing.


> 
> Following Joel's suggestion [1], we start with helpers that work for all
> existing patterns before making invasive changes.
Having these two patches makes the review much easier. thx for reducing
it.

> 
> 
> [1] https://lore.kernel.org/all/sytyqb3ajm6ysoifwp57ga7gzlnzodhdsbgizbn3hqnlwytn5a@pbscftrq2qwl/
> [2] https://sysctl-dev-rtd.readthedocs.io/en/latest/notes/ctltable_entry_macro.html#table-entry-macro

Feel free to send a PR to https://github.com/Joelgranados/sysctl_dev_rtd
if you want to include any notes in the sysctl-dev-rtd.

> 
> 
> Wen Yang (2):
>   sysctl: introduce SYSCTL_ENTRY() helper macro
>   sysctl: convert kernel/sysctl-test.c to use SYSCTL_TBL_ENTRY()
> 
>  include/linux/sysctl.h | 131 ++++++++++++++++++++++++++++++++++++++
>  kernel/sysctl-test.c   | 139 ++++++++++++-----------------------------
>  2 files changed, 171 insertions(+), 99 deletions(-)
> 
> -- 
> 2.25.1
> 

-- 

Joel Granados

Attachment: signature.asc
Description: PGP signature