Re: [PATCH v2 3/3] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs

[Rakesh Kota]

On Tue, Feb 17, 2026 at 01:30:19PM +0100, Konrad Dybcio wrote:
> On 2/9/26 2:23 PM, Rakesh Kota wrote:
> > Add the Power On (PON) peripheral with power key and reset input
> > support for the PMM8654AU PMIC on Monaco platforms.
> > 
> > Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/monaco-pmics.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > index e990d7367719beaa9e0cea87d9c183ae18c3ebc8..182c2339bb11af40275050a36c4688227e89497a 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/monaco-pmics.dtsi
> > @@ -13,6 +13,26 @@ pmm8620au_0: pmic@0 {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> >  
> > +		pmm8654au_0_pon: pon@1200 {
> > +			compatible = "qcom,pmm8654au-pon", "qcom,pmk8350-pon";
> > +			reg = <0x1200>, <0x800>;
> > +			reg-names = "hlos", "pbs";
> > +
> > +			pmm8654au_0_pon_pwrkey: pwrkey {
> > +				compatible = "qcom,pmm8654au-pwrkey", "qcom,pmk8350-pwrkey";
> > +				interrupts-extended = <&spmi_bus 0x0 0x12 0x7 IRQ_TYPE_EDGE_BOTH>;
> > +				linux,code = <KEY_POWER>;
> > +				debounce = <15625>;
> > +			};
> > +
> > +			pmm8654au_0_pon_resin: resin {
> > +				compatible = "qcom,pmm8654au-resin", "qcom,pmk8350-resin";
> > +				interrupts-extended = <&spmi_bus 0x0 0x12 0x6 IRQ_TYPE_EDGE_BOTH>;
> > +				linux,code = <KEY_VOLUMEDOWN>;
> > +				debounce = <15625>;
> 
> FWIW we tend to disable RESIN by default, as it's not as ubiquitous as
> the power key and only assign the keycode in board DT, since it may
> commonly be reused for either of the volume keys (or something else
> entirely)
>
Ok, i will disable the RESIN key by default and remove the assigned
keycode in the next patch revision.

regards
Rakesh Kota

> Konrad