Re: [PATCH] ASoC: rockchip: i2s-tdm: Use param rate if not provided by set_sysclk
From: Mark Brown
Date: Thu Feb 19 2026 - 07:34:59 EST
On Thu, Feb 19, 2026 at 10:37:18AM +0100, Alexandre Belloni wrote:
> On 18/02/2026 15:18:34-0500, Detlev Casanova wrote:
> > + if (!mclk_rate)
> > + mclk_rate = DEFAULT_MCLK_FS * params_rate(params);
> > +
> Maybe this could be set as the default value of i2s_tdm->mclk_rx_freq
> and i2s_tdm->mclk_tx_freq in rockchip_i2s_tdm_probe instead of relying
> on it being 0 and testing later on?
That makes sense but since this is fixing a regression and I'd like to
get the fix in I'll apply, we can improve things incrementally.
Attachment:
signature.asc
Description: PGP signature