Re: [PATCH] staging: greybus: document codec mutex usage
From: Dan Carpenter
Date: Thu Feb 19 2026 - 09:34:28 EST
On Thu, Feb 19, 2026 at 02:28:19PM +0100, Bartłomiej Konecki wrote:
> Add comments describing lock and register_mutex
> in struct gbaudio_codec_info.
> The lock protects the codec runtime state and module/DAI lists, while
> register_mutex protects hardware registers.
> Improve readability and clarify locking semantics.
>
> Signed-off-by: Bartłomiej Konecki <bartekkonecki97@xxxxxxxxx>
> ---
> drivers/staging/greybus/audio_codec.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index f3f7a7ec6be4..90dd3426d4a4 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -70,8 +70,9 @@ struct gbaudio_codec_info {
> struct list_head module_list;
> /* to maintain runtime stream params for each DAI */
> struct list_head dai_list;
> - struct mutex lock;
> + struct mutex lock; /* protects codec state and module/DAI lists */
> struct mutex register_mutex;
> + /* serializes access to codec hardware registers*/
No, it doesn't.
regards,
dan carpenter