Re: [PATCH v4 2/6] rust: helpers: Add bindings/wrappers for dma_resv_lock

[Danilo Krummrich]

On Fri Jan 30, 2026 at 3:24 PM CET, Alice Ryhl wrote:
> From: Asahi Lina <lina+kernel@xxxxxxxxxxxxx>
>
> This is just for basic usage in the DRM shmem abstractions for implied
> locking, not intended as a full DMA Reservation abstraction yet.
>
> Signed-off-by: Asahi Lina <lina+kernel@xxxxxxxxxxxxx>
> Signed-off-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>
> Reviewed-by: Janne Grunau <j@xxxxxxxxxx>
> Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> ---
> Taken from:
> https://lore.kernel.org/all/20251202220924.520644-3-lyude@xxxxxxxxxx/
> with __rust_helper added.
> ---
>  MAINTAINERS                     |  1 +
>  rust/bindings/bindings_helper.h |  1 +
>  rust/helpers/dma-resv.c         | 14 ++++++++++++++
>  rust/helpers/helpers.c          |  1 +
>  4 files changed, 17 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 618becae72985b9dfdca8469ee48d4752fd0ca41..8d44728261ffa82fc36fa0c5df3b11a5bfb4339b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7467,6 +7467,7 @@ L:	rust-for-linux@xxxxxxxxxxxxxxx
>  S:	Supported
>  W:	https://rust-for-linux.com
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git
> +F:	rust/helpers/dma-resv.c
>  F:	rust/helpers/dma.c
>  F:	rust/helpers/scatterlist.c
>  F:	rust/kernel/dma.rs

That's fine for me in general, but maybe the DMA BUFFER SHARING FRAMEWORK is
probably the correct place. DMA BUFFER SHARING FRAMEWORK is also under the DRM
umbrella, so we should also add it to the drm-rust entry as well.