Re: [PATCH 1/8] printk: Rename struct console_cmdline to preferred_console

[Chris Down]

The rename itself looks correct and is a clear improvement. Only one small 
thing:

Petr Mladek writes:
> -static void set_user_specified(struct console_cmdline *c, bool user_specified)
> +static void set_user_specified(struct preferred_console *pc, bool user_specified)
> {
> 	if (!user_specified)
> 		return;
> @@ -2500,7 +2500,7 @@ static void set_user_specified(struct console_cmdline *c, bool user_specified)
> 	 * @c console was defined by the user on the command line.
> 	 * Do not clear when added twice also by SPCR or the device tree.
> 	 */

The comment is stale, it should be @pc.

With that fix:

Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>