Re: [PATCH 7/8] printk: Handle pre-enabled consoles directly in register_console()

[Chris Down]

Petr Mladek writes:
> The function try_enable_preferred_console() currently has the
> non-obvious side effect of returning success for consoles that are
> already pre-enabled. This obscures the logic flow during console
> registration.
>
> Move the check for pre-enabled consoles directly into
> register_console(). This change makes the handling of pre-enabled
> consoles explicit and easier to follow.
>
> Furthermore, this separation lays the groundwork for future cleanups
> where try_enable_preferred_console() can be restricted to cases where
> an entry actually exists in the preferred_consoles[] array.
>
> Possible behavior change:
>
> try_enable_preferred_console() will newly be called also with
> @user_specified parameter set to "false" when it failed with the "true"
> variant. But it looks like the right way to do. It will allow to call
> newcon->setup() when the console was preferred by some platform
> specific code.
>
> Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>

Looks cracking, thanks.

Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>