Re: [RFC net-next 2/4] ethtool: module: Add CMIS loopback GET/SET support

[Andrew Lunn]

> + * struct ethtool_module_loopback_params - module loopback parameters
> + * @caps: The loopback types, %ETHTOOL_MODULE_LOOPBACK_TYPES_*,
> + *	supported by the module.
> + * @enabled: The loopback types, %ETHTOOL_MODULE_LOOPBACK_TYPES_*,
> + *	currently enabled by the module.
> + */
> +struct ethtool_module_loopback_params {
> +	u32 caps;
> +	u32 enabled;

You probably should be using ethtools bitset API for this.

    Andrew