Re: [PATCH v2 1/3] iio: frequency: ad9523: fix implicit variable usage in macros

[Andy Shevchenko]

On Fri, Feb 20, 2026 at 02:02:13AM +0530, bhargav wrote:
> macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and
> AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable
> named 'ret' instead of using passed argument 'x'.
> 
> Update the macros to explicitly
> use the argument 'x' for their operations.
> 
> This also resolves the following checkpatch.pl warning:
> WARNING: Argument 'x' is not used in function-like macro

...

>  #define AD9523_CLK_DIST_DIV_PHASE(x)		(((x) & 0x3F) << 18)
> -#define AD9523_CLK_DIST_DIV_PHASE_REV(x)	((ret >> 18) & 0x3F)
> +#define AD9523_CLK_DIST_DIV_PHASE_REV(x)	((x >> 18) & 0x3F)

See above, this should be '(x)' and not 'x'.

...

>  #define AD9523_CLK_DIST_DIV(x)			((((x) - 1) & 0x3FF) << 8)
> -#define AD9523_CLK_DIST_DIV_REV(x)		(((ret >> 8) & 0x3FF) + 1)
> +#define AD9523_CLK_DIST_DIV_REV(x)		(((x >> 8) & 0x3FF) + 1)

Ditto.

-- 
With Best Regards,
Andy Shevchenko