Re: [PATCH V2 2/3] hwmon: (ina2xx) Make it easier to add more devices

[Bence Csókás]

Hi,

On 2/19/26 16:59, Guenter Roeck wrote:
> On 2/19/26 05:01, Ian Ray wrote:
> > diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> > index 69ac0468dee4..4bf609e25f8a 100644
> > --- a/drivers/hwmon/ina2xx.c
> > +++ b/drivers/hwmon/ina2xx.c
> > @@ -46,9 +46,11 @@
> >   #define INA2XX_CURRENT            0x04 /* readonly */
> >   #define INA2XX_CALIBRATION        0x05
> > -/* INA226 register definitions */
> > +/* INA2xx register definitions */
>
> There was a reason for this. INA219 does not support those registers
> or, more generically, they are only supported on chips supporting
> alert limits.
>
> >   #define INA226_MASK_ENABLE        0x06
> >   #define INA226_ALERT_LIMIT        0x07
> > +
> > +/* INA226 register definitions */
> >   #define INA226_DIE_ID            0xFF
>
> That isn't even used, and the comment is wrong (at least INA230 and INA260
> also support it). Might as well drop it.
>
> Either case, is that bike shedding really necessary ? The only really 
> valuable
> change in this patch is the introduction of has_update_interval. Please 
> keep that
> and drop the rest.
>
> Thanks,
> Guenter

I agree _this one_ hunk could be dropped. For the rest:

Reviewed-by: Bence Csókás <bence98@xxxxxxxxxx>

Bence