Re: [PATCH v2] ARM: dts: aspeed: anacapa: Add retimer EEPROMs

[Andrew Jeffery]

Hi Dirk,

On Thu, 2026-02-19 at 15:54 +0000, Chen, Dirk wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]

Please have a read through [1], in particular:

[1]: https://subspace.kernel.org/etiquette.html

   Do not include “confidentiality disclaimers”

   When posting to public mailing lists the boilerplate confidentiality
   disclaimers are not only meaningless, they are absolutely wrong for
   obvious reasons.
   
   If that disclaimer is automatically inserted by your corporate e-mail
   infrastructure, talk to your manager, IT department or consider using a
   different e-mail address which is not affected by this policy. Many IT
   companies have dedicated e-mail infrastructure for kernel developers to
   specifically avoid this situation.

> 
> Hi Andrew,
> 
> > +     eeprom@50 {
> > Please order these nodes by ascending address. The node currently above this one is i2c-mux@70 - eeprom@50 should go before it.
> > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
> 
> Thanks for the reminder.
> I've reordered the nodes by ascending address in v3.
> 
> > +             compatible = "atmel,24c2048";
> > +             reg = <0x50>;
> > +             pagesize = <128>;
> > +     };
> >  };
> > +     eeprom@50 {
> > Same for this one.
> 
> Fixed in v3 as well.
> 

Thanks,

Andrew