Re: [PATCH] ARM: dts: qcom: msm8960: expressatt: Add coreriver,tc360-touchkey
From: Rudraksha Gupta
Date: Thu Feb 19 2026 - 23:34:04 EST
Hello all,
Top posting for once (context below).
Not too sure what the next steps are to get the tm2 touchkey in. Should I resend the patch, contact someone else that can help provide guidance, or something else?
Adding Dmitry Torokhov (official maintainer) and Nick Reitemeyer (person who introduced this variant).
Thanks,
Rudraksha
On 12/16/25 04:59, Konrad Dybcio wrote:
On 12/9/25 8:10 AM, Rudraksha Gupta wrote:
[...]Add the tc360 touchkey. It's unknown if this is the actual model of theThis driver mentions a register called CYPRESS_MODULE_VER - maybe
touchkey, as downstream doesn't mention a variant, but this works.
Link:
https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/input/keyboard/cypress_touchkey_236/Makefile#L5
it could help confirm the model?
Konrad
When run on mainline, this is what was outputted:Sounds like the best idea, I have no clue either
samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/module_version
0x06
samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/fw_version
0x09
fw_version matches downstream ClockworkMod Recovery dmesg:
~ # dmesg | grep "FW Ver"
<3>[ 2.201312] cypress_touchkey 16-0020: Touchkey FW Version: 0x09
<3>[ 2.206317] cypress_touchkey 16-0020: Touchkey FW Version: 0x09, system_rev: 8
Unfortunately, I'm not to sure what the other variant versions are, so I will CC the driver's maintainers:
MODULE_AUTHOR("Beomho Seo <beomho.seo@xxxxxxxxxxx>");
MODULE_AUTHOR("Jaechul Lee <jcsing.lee@xxxxxxxxxxx>");
Konrad