Re: [PATCH v3 1/3] iio: frequency: ad9523: fix implicit variable usage in macros

From: Andy Shevchenko

Date: Fri Feb 20 2026 - 02:21:51 EST


On Fri, Feb 20, 2026 at 03:05:47AM +0530, bhargav wrote:
> macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and

The macros

> AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable
> named 'ret' instead of using passed argument '(x)'.
>
> Update the macros to explicitly
> use the argument '(x)' for their operations.

Something with wrapping of the lines, use up to ~72 characters per line.

> This also resolves the following checkpatch.pl warning:
> WARNING: Argument '(x)' is not used in function-like macro

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko