Re: [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure

From: Andy Shevchenko

Date: Fri Feb 20 2026 - 02:52:31 EST


On Fri, Feb 20, 2026 at 11:09:38AM +0530, Sai Krishna Potthuri wrote:
> Add setup_channels function pointer to xadc_ops structure to enable

Add .setup_channels()...

...to struct xadc_ops to enable...

> different interfaces to have custom channel setup logic.

...

> +static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq);

This is a red flag. Why do we need a forward declaration? Bad architecture /
design of the function calls?

--
With Best Regards,
Andy Shevchenko