Re: [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 data pins

[Moteen Shah]

On 13/02/26 00:12, Judith Mendez wrote:
> AM62 LP SK board does not have external pullups on MMC0 D1-D7 pins [0],
> enable internal pullups considering:
> - floating lines violate JDEC spec recommendations
> - mismatched pullup resistace between D0 and D1-D7 may cause potential
>    issues for modes with tighter timing requirements. The different pull-up
>    values cause different rise/fall times on each data line.
>
> Fixes: a0b8da04153e ("arm64: dts: ti: k3-am62*: Move eMMC pinmux to top level board file")
> [0] https://www.ti.com/lit/zip/SPRR471
> Signed-off-by: Judith Mendez <jm@xxxxxx>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> index 3e2d8f6695351..8a556fbbe08b7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> @@ -88,13 +88,13 @@ main_mmc0_pins_default: main-mmc0-default-pins {
>   			AM62X_IOPAD(0x220, PIN_INPUT, 0) /* (V3) MMC0_CMD */
>   			AM62X_IOPAD(0x218, PIN_INPUT, 0) /* (Y1) MMC0_CLK */
>   			AM62X_IOPAD(0x214, PIN_INPUT, 0) /* (V2) MMC0_DAT0 */
> -			AM62X_IOPAD(0x210, PIN_INPUT, 0) /* (V1) MMC0_DAT1 */
> -			AM62X_IOPAD(0x20c, PIN_INPUT, 0) /* (W2) MMC0_DAT2 */
> -			AM62X_IOPAD(0x208, PIN_INPUT, 0) /* (W1) MMC0_DAT3 */
> -			AM62X_IOPAD(0x204, PIN_INPUT, 0) /* (Y2) MMC0_DAT4 */
> -			AM62X_IOPAD(0x200, PIN_INPUT, 0) /* (W3) MMC0_DAT5 */
> -			AM62X_IOPAD(0x1fc, PIN_INPUT, 0) /* (W4) MMC0_DAT6 */
> -			AM62X_IOPAD(0x1f8, PIN_INPUT, 0) /* (V4) MMC0_DAT7 */
> +			AM62X_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (V1) MMC0_DAT1 */
> +			AM62X_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (W2) MMC0_DAT2 */
> +			AM62X_IOPAD(0x208, PIN_INPUT_PULLUP, 0) /* (W1) MMC0_DAT3 */
> +			AM62X_IOPAD(0x204, PIN_INPUT_PULLUP, 0) /* (Y2) MMC0_DAT4 */
> +			AM62X_IOPAD(0x200, PIN_INPUT_PULLUP, 0) /* (W3) MMC0_DAT5 */
> +			AM62X_IOPAD(0x1fc, PIN_INPUT_PULLUP, 0) /* (W4) MMC0_DAT6 */
> +			AM62X_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (V4) MMC0_DAT7 */
>   		>;
>   	};
>   


Same question as of the other patch, won't the mismatch in resistance 
between D0 and other data lines will cause an issue here.

Regards,
Moteen