Re: [PATCH v4 05/24] x86/virt/seamldr: Retrieve P-SEAMLDR information

[Huang, Kai]

> +int seamldr_get_info(struct seamldr_info *seamldr_info)
> +{
> +	struct tdx_module_args args = { .rcx = slow_virt_to_phys(seamldr_info) };

Should we have a comment for slow_virt_to_phys()?  This patch alone doesn't
really tell where is the memory from.

Btw, it it were me, I would just merge this patch with the next one.  Then
it's clear the memory comes from tdx-host module's stack.  The merged patch
won't be too big to review either (IMHO).  You can then have this
seamldr_get_info() and its user together in one patch, with one changelog to
tell the full story.

But just my 2cents, feel free to ignore. 

> +
> +	return seamldr_call(P_SEAMLDR_INFO, &args);
> +}
> +EXPORT_SYMBOL_FOR_MODULES(seamldr_get_info, "tdx-host");
> -- 
> 2.47.3