Re: [PATCH v1 1/1] iio: core: Simplify IIO core managed APIs

[Nuno Sá]

On Tue, 2026-02-17 at 15:32 +0200, Andy Shevchenko wrote:
> On Tue, Feb 17, 2026 at 01:29:07PM +0000, Nuno Sá wrote:
> > On Tue, 2026-02-17 at 09:45 +0200, Andy Shevchenko wrote:
> > > On Mon, Feb 16, 2026 at 02:31:57PM +0000, Nuno Sá wrote:
> > > > On Mon, 2026-02-16 at 09:14 +0100, Andy Shevchenko wrote:
> 
> ...
> 
> > > > > -	if (!buffer)
> > > > > -		return -ENOMEM;
> > > > > +	if (IS_ERR(buffer))
> > > > > +		return PTR_ERR(buffer);
> > > > 
> > > > Subtle change that could have been mentioned in the commit message.
> > > 
> > > Actually not really a change. Currently the error code is shadowed to -ENOMEM,
> > 
> > Well before that was explicit. Now it also depends on the internals of  __devm_add_action().
> 
> True, but if that ever changed, we will have a new error code coming from
> ->probe() and that's fine. ->probe() is not stricted to the certain error codes.

Note that I'm not complaining about the change. Just that it could have been mentioned
in the commit :)

- Nuno Sá
>